chore: reduce log verbosity for backup-handler#4063
Open
rocketeerbkw wants to merge 1 commit intomainfrom
Open
chore: reduce log verbosity for backup-handler#4063rocketeerbkw wants to merge 1 commit intomainfrom
rocketeerbkw wants to merge 1 commit intomainfrom
Conversation
unable to handle webhook, data is:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
n/a
Description
k8up sends webhooks to the
backup-handlerfor certain events, and there is a fallback that logs the webhook data if the webhook can't be handled. For every snapshot, k8up sends two webhooks: 1) a webhook with progress/metrics information about the single snapshot and 2) a webhook with a list of all snapshots.Currently, scenario (1) results in a log being printed, and this PR adds a check to exclude it, since it is a webhook that is known to not be handled. This reduces logs by ~30%.
Example extraneous log (formatted for clarity):
Closing issues
n/a