Open
Conversation
Overview
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the API user lookup so that userByEmail() can optionally return a user’s platform roles by enriching the loaded user object, using the same gating logic as the platform-admin “all platform users” flow.
Changes:
- Add
UserModel.enrichUserWithPlatformRoles()to fetch and attach Keycloak realm platform roles to aUser. - Update
getUserByEmailresolver to enrich the returned user withplatformRolesfor platform owners/viewers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| services/api/src/resources/user/resolvers.ts | Enriches userByEmail results with platform roles when caller has platform admin scopes. |
| services/api/src/models/user.ts | Adds a model helper to fetch realm role mappings and attach platform roles to the user object. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
shreddedbacon
approved these changes
Mar 17, 2026
Member
shreddedbacon
left a comment
There was a problem hiding this comment.
Ran locally, roles in userByEmail query are populated as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the user model with a convenience function that lets one enrich a user object with the platform roles.
This is then used to plug a hole in the current "userByEmail()" query, which doesn't actually return platform roles.
The enrichment is gated by the same logic used by the allPlatformUsers query.