use quotes to reference the runnerPath when spewing the command fixes #105#106
Open
jwoodrow wants to merge 1 commit intousabilityhub:masterfrom
Open
use quotes to reference the runnerPath when spewing the command fixes #105#106jwoodrow wants to merge 1 commit intousabilityhub:masterfrom
jwoodrow wants to merge 1 commit intousabilityhub:masterfrom
Conversation
Collaborator
|
Thanks for your PR! |
Contributor
|
Yes, on Yarn 4.x I've got this failure running a pet project with Using the 'moonproject:master' branch solved the issue. I've took a glance at the tests, but have no idea how to test this. Weird is, testing this branch results in this, cited above, error on 9 tests. Everything's OK, though, when running the app (development mode). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the rails runner interprets anything starting with a
/as a regex so when therunnerPathends up being an absolute path it breaks.fixes #105