fix: take unique into account when counting with sqlalchemy#791
Open
lqmanh wants to merge 1 commit intouriyyo:mainfrom
Open
fix: take unique into account when counting with sqlalchemy#791lqmanh wants to merge 1 commit intouriyyo:mainfrom
lqmanh wants to merge 1 commit intouriyyo:mainfrom
Conversation
uriyyo
force-pushed
the
main
branch
3 times, most recently
from
45f9550 to
b841ebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My proposal to resolve #674
Given that we already have
unique: boolparam and use it when resolving items, it makes sense to apply it when counting as well.