retrieve: u3r_met returns c3_d#1034
Open
matthew-levan wants to merge 7 commits into
Open
Conversation
We do this so we don't allocate the same peer multiple times if we process multiple packets from them before the routes get returned from the arvo scry.
Collaborator
|
The assertion pattern used here replaces the recoverable |
promotes `u3r_met` to return `c3_d` so it no longer truncates the bit/byte length of big atoms. sweeps every callsite: comparisons are left as-is, values feeding 64-bit consumers (`u3i_slab_init`, `u3r_chop_words` widths) are widened to `c3_d`, and values that need 32-bit width get a recoverable `bail:fail` guard before an explicit `(c3_w)` narrow, preserving the behavior u3r_met previously raised on overflow. `rap`/`rep` keep their 32-bit `tot_w` overflow guards. `met`/`xeb` now return via `u3i_chub` so counts past `2^31` produce a correct atom instead of a truncated one.
Contributor
Author
|
@joemfb thank you, fixed. |
Replaces 404'ing link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promotes
u3r_metto returnc3_dso it no longer truncates the bit/byte length of big atoms.sweeps every callsite: comparisons are left as-is, values feeding 64-bit consumers (
u3i_slab_init,u3r_chop_wordswidths) are widened toc3_d, and values that need 32-bit width get a recoverablebail:failguard before an explicit(c3_w)narrow, preserving the behavior u3r_met previously raised on overflow.rap/repkeep their 32-bittot_woverflow guards.met/xebnow return viau3i_chubso counts past2^31produce a correct atom instead of a truncated one.