[lint-provider-family]: Allow the family labels on config packages#124
Open
ulucinar wants to merge 2 commits intoupbound:mainfrom
Open
[lint-provider-family]: Allow the family labels on config packages#124ulucinar wants to merge 2 commits intoupbound:mainfrom
ulucinar wants to merge 2 commits intoupbound:mainfrom
Conversation
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
family-linter-config-allow-label
branch
from
19a9717 to
680e93e
Compare
…e metadata Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
family-linter-config-allow-label
branch
from
e43e144 to
0a9efd1
Compare
ulucinar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Successfully linted AWS, Azure & GCP provider families versions
v0.36.0,v0.33.0&v0.33.0, respectively with the first commit of this PR.Tested the second commit on
index.docker.io/ulucinar/{provider-family-azure,provider-azure-devices}:{v0.1.0-fix470, v0.2.0-fix470}.