Fix guest parser offset on the last line with CRLF line endings#4267
Open
b4n wants to merge 2 commits intouniversal-ctags:masterfrom
Open
Fix guest parser offset on the last line with CRLF line endings#4267b4n wants to merge 2 commits intouniversal-ctags:masterfrom
b4n wants to merge 2 commits intouniversal-ctags:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4267 +/- ##
=======================================
Coverage 85.95% 85.95%
=======================================
Files 246 246
Lines 63470 63435 -35
=======================================
- Hits 54554 54526 -28
+ Misses 8916 8909 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@masatake I have a fix that mostly look reasonable, but I'm still not sure I get everything around this, so please review carefully and don't trust the logic :) Results seem solid though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #4266, and is basically the test part of #4097 that is actually still relevant, only the CRLF got lost in translation.
This is just a test case showing the issue, so we have something to work on.
FWIW, here's the output:
If we trick mini-geany to run it, it's worse:
But that's only because with it the
fatal()call does not callexit(), and thus does not prevent the use of anNULLsubmio.