fix: emulator CPU state sync on hook only should sync pc, and fix pc syncing on mmio_map callback#2285
Open
appleflyerv3 wants to merge 7 commits intounicorn-engine:devfrom
Open
fix: emulator CPU state sync on hook only should sync pc, and fix pc syncing on mmio_map callback#2285appleflyerv3 wants to merge 7 commits intounicorn-engine:devfrom
appleflyerv3 wants to merge 7 commits intounicorn-engine:devfrom
Conversation
Signed-off-by: appleflyerv3 <164886846+appleflyerv3@users.noreply.github.com>
appleflyerv3
changed the title
… sync. Signed-off-by: appleflyerv3 <164886846+appleflyerv3@users.noreply.github.com>
Signed-off-by: appleflyerv3 <164886846+appleflyerv3@users.noreply.github.com>
Signed-off-by: appleflyerv3 <164886846+appleflyerv3@users.noreply.github.com>
- previously, condexec was corrupting on hooks due to the PC sync also changing condexec state. now that we have changed hooks to use a only PC sync system without changing condexec, this issue should be fixed. Signed-off-by: appleflyerv3 <164886846+appleflyerv3@users.noreply.github.com>
Signed-off-by: appleflyerv3 <164886846+appleflyerv3@users.noreply.github.com>
… other variables to run. Signed-off-by: appleflyerv3 <164886846+appleflyerv3@users.noreply.github.com>
Member
|
@appleflyerv3 have you solved your issue with this PR? I'm a bit losing the context. |
Author
|
yes its fixed in this PR, tested and works |
Author
|
pc is always synced properly when using hooks whereby it doesn't affect anything other than the pc on sync, and pc syncing has been added for mmio map |
Author
|
you may also observe the added CI tests in this PR, and they pass on my PR but not on latest 2.1.5-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.