Conversation
roozbehp
force-pushed
the
roozbehp-mid-conf
branch
from
0d0a6f7 to
5f9c869
Compare
Also Remove TestSecurity#TestSpacing that was overreaching: we now have cases where one side is non-spacing while the other has spacing characters. This happens because invisible stackers change spacing characters into nonspacing subjoined characters and we have confusable pairs where one side is a combining below form and another is a invisible stacker with a normal letter, which gets turned into a subjoined form. Takes care of parts of unicode-org/properties#460 The confusable pairs that are based on decompositions need more code work.
roozbehp
force-pushed
the
roozbehp-mid-conf
branch
from
5f9c869 to
dae26e2
Compare
Contributor
Author
|
@josh-hadley This is ready for review. The build errors already exist in the trunk. |
josh-hadley
approved these changes
Dec 23, 2025
Collaborator
josh-hadley
left a comment
josh-hadley
left a comment
There was a problem hiding this comment.
😅 a lot in here...looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also Remove TestSecurity#TestSpacing that was overreaching: we now have
cases where one side is non-spacing while the other has spacing characters.
This happens because invisible stackers change spacing characters into
nonspacing subjoined characters and we have confusable pairs where one side
is a combining below form and another is a invisible stacker with a normal
letter, which gets turned into a subjoined form.
Takes care of parts of https://github.com/unicode-org/properties/issues/460
The confusable pairs that are based on decompositions need more code work.