wip: add option to compute cluster by property#2855
Draft
yohanboniface wants to merge 3 commits intomasterfrom
Draft
wip: add option to compute cluster by property#2855yohanboniface wants to merge 3 commits intomasterfrom
yohanboniface wants to merge 3 commits intomasterfrom
Conversation
Overriding MarkerCluster is fragile, and we've made quite a lot of monkeypatches. Plus we want to prepare the possibility to cluster semantically, not only geographicaly. And when we'll have layer groups, to cluster a whole group (so combining amounts and colors). This clustering algorithm is very very naive, but uMap is not meant to be used with millions of points, so it may be enough for our usages. Let's see and improve later if needed. Still needed: - playwright tests - spiderify function when reaching max zoom and some markers are still on the same cluster (eg. same exact position) - allow to cluster on a property (eg. a region name) - allow to define a max zoom for clustering (eg. when zooming over the "region zoom", let's uncluster) - allow to display a custom aggregation instead of length in the cluster marker (eg. display the total amount of money spent) fix #326 cf #115 cf #508 cf #2675
yohanboniface
force-pushed
the
cluster-revamp
branch
from
0dbd3f2 to
e762c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.