Merged
Conversation
References to 'nightly' or just julia 1 will break as julia new julia versions are created, purely because the Project.toml and docs/Project.toml specify a particular range of julia versions.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Julia and Pkg compatibility range from 1.4-1.11 to 1.4-1.12 in the main Project.toml, enabling the package to work with Julia 1.12. The CI workflow has been updated to test against Julia 1.12 instead of nightly builds.
Key Changes:
- Extended Julia and Pkg compatibility to version 1.12 in Project.toml
- Replaced 'nightly' with '1.12' in the CI test matrix to ensure compatibility with version-restricted dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Project.toml | Updated Julia and Pkg compatibility ranges from "1.4 - 1.11" to "1.4 - 1.12" |
| .github/workflows/CI.yml | Changed test matrix to use Julia 1.12 instead of nightly, and pinned docs build to Julia 1.10 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
A more useful comment for future developers Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project.toml restricts this to julia 1.4 - 1.11, I checked and all tests pass on julia 1.12