Pull Request for default_room, default_item on Openworld/default#631
Pull Request for default_room, default_item on Openworld/default#631
Conversation
…lloc(). Tests and modules still compile.
…endencies on the root directory CMakeLists so we can run tests. I will branch from here and make tests for autogenerate before attempting a PR
…cts.c to be available to conduct the test and make more tests. Wait for either the PR of gen_structs to go through or specifically request source code access
… So fresh! So flirty!
Some functions were included. Here, I'm treating NPC characters similarly to items. Later on, I think it would be good to use the sample conversations the NPC team has already created within their sandbox.
carolinaecalderon
left a comment
carolinaecalderon
left a comment
There was a problem hiding this comment.
I fixed the description for default_rooms like Nicole wanted.
navila-luna
left a comment
navila-luna
left a comment
There was a problem hiding this comment.
The comments look more concise!
dwahme
left a comment
dwahme
left a comment
There was a problem hiding this comment.
Well done, we're pretty close. Mostly stylistic changes for chiventure conventions
Also, @navila-luna's npc files are in here. PR #639 seems to be where those should be added, so you should remove them from this PR
…iventure into openworld/default
…it's returning null items now
|
I'm not sure why the build on Travis is failing if I'm able to compile on the CSIL machines. My suspicion is that the copy_item_to_hash is returning NULL somewhere, but, again, not sure because the tests that I'm able to build all pass. |
|
On Tue, May 26, 2020 at 1:51 AM CCalderon01 ***@***.***> wrote:
I'm not sure why the build on Travis is failing if I'm able to compile on
the CSIL machines. My suspicion is that the copy_item_to_hash is returning
NULL somewhere, but, again, not sure because the tests that I'm able to
build all pass.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#631 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMOW7OQ3MB54KWM2WEF5NOTRTNKENANCNFSM4NI6UA7Q>
.
Where is this? Maybe I’m able to see where the issue is.
|
|
Issue Score: ✔️+ Comments: When an issue is done, you should include a final comment summarizing what was done, and why the issue is being closed. |
4 participants
For this pull request, I'm introducing the (at least mostly) finalized default_room and default_items modules. These modules do not contain any additional structs, but instead create hash tables to organize the 20+ "default" items and 10+ "default" rooms. In this case, default means that the item or room is assigned fixed description strings and even fixed subset of allowed items (for rooms). The hash tables will provide added flexibility for future expansion of Chiventure.
For more information, refer to my issue for Sprint 3: #540.
(A quick note about the number of commits this pull request has listed: I have a weird set-up on my home laptop and the CSIL server that I ssh into. I don't like coding on Vim if I can avoid it, so it's much easier for me to write/heavily edit my code on my home server. However, I can't test on my home server. Instead, I have to go back and forth between my home server, committing my changes, testing on CSIL, committing even smaller bug fixes, and returning back to my home server to keep writing my code. It's not the smoothest process, hence why I have a larger than normal amount of commits, but I prefer my home coding environment.)