Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 56 56
Lines 5279 5279
=======================================
Hits 4693 4693
Misses 586 586 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "cancel-in-progress" concurrency option has proved to be problematic at times. Besides the bad interactions with TiCS, sometimes workflows get cancelled, but they never actually get replaced with a fresh one.
Though the TiCS interaction has been roughly resolved previously with a workaround, it appears to be better to just not cancel in-progress runs on main. Since this is an open repository, and we're not using any special GitHub runners, we shouldn't get charged by GitHub for runner usage.
However, simply disabling cancel in progress with the existing setup would mean it could potentially take a very long time to get relevant results. Thus, instead, here we define the concurrency groups such that they should be irrelevant when the ref is main. To ensure that TiCS doesn't break, we add a strict, non-cancelling job-level concurrency group to the "Process coverage reports" job in
QA.