update docs for duckdb, java for v4.4.0#1088
Merged
Merged
Conversation
isaacbrodsky
requested review from
ajfriend,
dfellis,
dmitryzv and
nrabinowitz
ajfriend
reviewed
Nov 30, 2025
Comment on lines
+342
to
+343
| const res = 2; | ||
| return h3.constructCell(baseCellNumber, [0], res); |
Collaborator
There was a problem hiding this comment.
Should this be res = 1. FWIW, here's the example and error in h3-py:
>>> h3.construct_cell(0, 0, res=2)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/aj/work/h3-py/env/lib/python3.12/site-packages/h3/api/basic_str/__init__.py", line 829, in construct_cell
raise ValueError('Resolution must match number of digits.')
ValueError: Resolution must match number of digits.
ajfriend
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on new versions of h3-duckdb and h3-java being released, e.g. uber/h3-java#192