Improvements to similar contact name comparison#10639
Open
Improvements to similar contact name comparison#10639
Conversation
Normailze contact names before comparison. Close #10497 Co-authored-by: hrb-hub <hrb-hub@users.noreply.github.com>
7 tasks
wrdhub
reviewed
Apr 9, 2026
| export function _normalizeContactName(name: string): string { | ||
| return name | ||
| .toLowerCase() | ||
| .split(" ") |
Contributor
There was a problem hiding this comment.
is there a reason we don't trim before the split?
| o.check(_areContactsNamesSimilar(c1, c2)).equals(true) | ||
| c1 = createEmailPhoneContact("anton", "schmidt", null) | ||
| c2 = createEmailPhoneContact("schmidt", "anton", null) | ||
| o.check(_areContactsNamesSimilar(c1, c2)).equals(true) //mistake? |
Contributor
There was a problem hiding this comment.
I am also wondering about this, but this checking is just for suggesting contacts to merge, right? I can see names getting mixed up so this might be good, just to check. It could also be annoying if you get a lot of false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normailze contact names before comparison.
Close #10497