Open
Conversation
Co-authored-by: jomapp <17314077+jomapp@users.noreply.github.com>
Our regular expressions for mail preprocessing, for our client-side spam filter, suffers from catastrophic backtracking in some view cases, causing "too much recursion" errors for users on the WebApp. We now catch such errors during tokenization and do not include the mail body in the training / prediction in these cases. Co-authored-by: abp <abp@tutao.de>
When clicking the plus button without groups, the button had no feedback for the user, now it displays a popup asking if user wants to add a new shared mailbox, if yes it is assigned to the user. Co-authored-by: das <das@tutao.de> Co-authored-by: abp <abp@tutao.de>
When the cache storage is not initialized for some reason, e.g. due to weird concurrency, we should not try to write to it. In these cases it's still better to continue and load the instance from the server without writing it to the cache storage, instead of throwing an error. The cache storage is not initialized error is preventing users in some cases to do a login at all, which should always be possible. Co-authored-by: abp <abp@tutao.de>
abdulkadir-tutao
force-pushed
the
fix-cache-storage-not-initialized
branch
from
2a368c0 to
aa9a5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cache storage is not initialized for some reason, e.g. due to weird concurrency, we should not try to write to it. In these cases it's still better to continue and load the instance from the server without writing it to the cache storage, instead of throwing an error. The cache storage is not initialized error is preventing users in some cases to do a login at all, which should always be possible.