Skip to content

New layout#411

Merged
jeromekelleher merged 23 commits intotskit-dev:mainfrom
jeromekelleher:new-layout
Mar 5, 2026
Merged

New layout#411
jeromekelleher merged 23 commits intotskit-dev:mainfrom
jeromekelleher:new-layout

Conversation

@jeromekelleher
Copy link
Member

This is a work in progress - I'll have to see how SLiM fits in to the general workflows. The diff is noisy, but it's mainly just ruff updates which are harmless.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 98.27586% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.74%. Comparing base (137ae17) to head (636d283).

Files with missing lines Patch % Lines
pyslim/spatial.py 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   96.83%   96.74%   -0.09%     
==========================================
  Files           8        8              
  Lines         789      769      -20     
  Branches      146      146              
==========================================
- Hits          764      744      -20     
  Misses         15       15              
  Partials       10       10              
Flag Coverage Δ
python-tests 96.74% <98.27%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

micromamba install puts the executable into the slim-env environment bin
directory, which is not automatically on PATH in subsequent GitHub Actions
steps. Explicitly append the env bin dir to GITHUB_PATH.
setup-micromamba only adds the micromamba executable dir to PATH, not
the base environment bin dir. Slim installs to $MAMBA_ROOT_PREFIX/bin
so we must explicitly append that to GITHUB_PATH.
@jeromekelleher
Copy link
Member Author

This would generally be a lot easier if we could separate running tests and docs from running SLiM. Would you be up for restructuring things here so that tests and docs depend on known paths to tree sequence files, rather than running slim inline @petrelharp? If we did that I think we could use the general workflows for documentation and tests fairly straightforwardly (which would be good in the long run).

@petrelharp
Copy link
Contributor

This would generally be a lot easier if we could separate running tests and docs from running SLiM. Would you be up for restructuring things here so that tests and docs depend on known paths to tree sequence files, rather than running slim inline @petrelharp?

I'm okay with that restructuring in principle! But, one issue here is that something we test a fair bit is, for instance, "can pyslim do manipulations to tree sequences that are then readable by SLiM". So, either I misunderstand, or we'll still need to run slim inline in the tests?

@jeromekelleher jeromekelleher marked this pull request as ready for review March 4, 2026 14:12
@jeromekelleher
Copy link
Member Author

I think this is ready to go. I didn't end up making any real changes, as the SLiM invocations are pretty deeply embedded, and just updated the docs workflow to optionally install SLiM. The tests workflow is bespoke enough that it's not worth refactoring right now.

I had to skip some tests because of failures, but they've been broken for a while (#412).

It would be good to merge this ASAP @petrelharp as I'm trying to get a coordinated set of releases out so that the ecosystem is up to date and the top-level website build can be simplified.

@jeromekelleher
Copy link
Member Author

OK, I'm going to go ahead and merge this as no one has objected.

@jeromekelleher jeromekelleher merged commit b694797 into tskit-dev:main Mar 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants