feat(eval): add opt-in TI footprint resolver via runtime platform config#2771
feat(eval): add opt-in TI footprint resolver via runtime platform config#2771techmannih wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7704b99a46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| jlcPartsEngine, | ||
| type EasyEdaProxyConfig, | ||
| } from "@tscircuit/parts-engine" | ||
| import { createTiFootprintLibrary } from "@tscircuit/ti-parts-engine/footprint-library" |
There was a problem hiding this comment.
Import TI engine from its exported entrypoint
When this package is installed from the added github:tscircuit/ti-parts-engine dependency, @tscircuit/ti-parts-engine/footprint-library is not an exported subpath (the upstream package exports only . and re-exports createTiFootprintLibrary from its root entrypoint). Because this is a top-level import, any build or runtime import of getPlatformConfig fails module resolution before the opt-in tiBridgeConfig path can be used; import from @tscircuit/ti-parts-engine and bundle that package instead.
Useful? React with 👍 / 👎.
No description provided.