Skip to content

Add TI footprint support to eval platform config - #2762

Closed
techmannih wants to merge 5 commits into
tscircuit:mainfrom
techmannih:feat/eval-ti-footprint-support
Closed

Add TI footprint support to eval platform config#2762
techmannih wants to merge 5 commits into
tscircuit:mainfrom
techmannih:feat/eval-ti-footprint-support

Conversation

@techmannih

Copy link
Copy Markdown
Member

Summary

  • add optional TI footprint support to eval through tiPartsEngineConfig
  • wire getPlatformConfig(...) to provide a built-in ti: footprint resolver
  • preserve explicit platform override behavior while safely merging projectConfig.footprintLibraryMap
  • add focused tests for:
    • built-in footprint="ti:MSP430" support
    • custom projectConfig.footprintLibraryMap.ti merge behavior
    • preserving existing kicad: and jlcpcb: resolvers

Why

This prepares @tscircuit/eval to support footprint="ti:..." without requiring core changes.

The new support is opt-in through tiPartsEngineConfig, so TI integration can be enabled when needed while keeping the default platform behavior unchanged for other users.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: befe62503c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/worker.ts
@techmannih
techmannih requested a review from seveibar June 1, 2026 01:47

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont want to integrate ti to eval?

@seveibar

seveibar commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@techmannih show users how to use a custom platform config js file with a custom parts engine in the docs- modifications to eval should not be necessary

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions Bot closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants