Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Python packaging/build configuration to target newer Python versions (notably 3.13), alongside a few test formatting cleanups.
Changes:
- Update Python package metadata (version, classifiers, homepage) in
pyproject.toml. - Modify GitHub Actions workflow to run Python CI primarily on 3.13 and adjust build/benchmark Python versions.
- Minor formatting changes in Python tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| python/tests/test_e4m3.py | Adjusts an f-string formatting in an error message. |
| python/tests/test_distances.py | Re-formats an assertion for clarity. |
| python/pyproject.toml | Updates package metadata (version/homepage) and adds Python 3.13 classifier. |
| .github/workflows/all.yml | Refocuses CI to Python 3.13 and comments out Java/C++ jobs and Maven publishing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # lint-java: | ||
| # runs-on: "ubuntu-latest" | ||
| # continue-on-error: true | ||
| # name: Lint Java | ||
| # defaults: | ||
| # run: | ||
| # working-directory: java | ||
| # steps: |
There was a problem hiding this comment.
Java/C++ lint/tests and the Maven publishing workflow have been removed from the active jobs: section and left as a large commented-out block. Given the repo includes java/ and cpp/ and the README describes Java bindings, this effectively drops CI coverage and disables Maven releases. Prefer re-enabling these jobs (or moving them into a separate workflow) and deleting the commented-out code to avoid an unmaintainable workflow file.
| [project] | ||
| name = "voyager" | ||
| version = "2.0.10" | ||
| version = "2.1.1" |
There was a problem hiding this comment.
The project version is bumped to 2.1.1 as part of this PR, but the PR description only mentions migrating Python 3.13/3.14 builds. If this isn’t meant to be a release/version change, keep the version unchanged; otherwise update the PR description/changelog/release process accordingly.
|
|
||
| [project.urls] | ||
| Homepage = "https://github.com/spotify/voyager" | ||
| Homepage = "https://github.com/troph-team/voyager" |
There was a problem hiding this comment.
Homepage was changed to https://github.com/troph-team/voyager. This is a user-facing metadata change and seems unrelated to the stated goal (migrating Python builds). If the package is still published/maintained under the original project URL, revert this; otherwise call out the ownership/repo change explicitly in the PR description/release notes.
python/pyproject.toml
Outdated
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", |
There was a problem hiding this comment.
The classifiers still advertise support for Python 3.7, but requires-python is >=3.8. This metadata is inconsistent and can mislead users/installers; remove the 3.7 classifier (or lower requires-python if 3.7 is actually supported).
| matrix: | ||
| python-version: | ||
| - '3.8' | ||
| - '3.13' | ||
| os: ['ubuntu-latest', windows-latest, macos-latest] | ||
| - "3.13" | ||
| os: ["ubuntu-latest", windows-latest, macos-latest] |
There was a problem hiding this comment.
The PR description mentions migrating to Python 3.13 and 3.14 builds, but the test matrix only runs on 3.13. Either add 3.14 to the matrix (if intended) or update the PR description; also consider keeping the minimum supported version (per requires-python >=3.8) in CI to catch compatibility issues early.
Description
This PR tries to migrate voyager with py3.13 and 3.14 build
Python
change pyproject toml and build workflows