Skip to content

Conversation

@folkertdev
Copy link
Member

No description provided.


*.zst binary
*.tar.zst binary
*.tar binary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this git starts messing with the line endings, changing the file.

match_2 = base.offset(matchIndex as isize);
if matchIndex >= dictLimit {
assert!(libc::memcmp(match_2.cast(), ip.cast(), matchLength) == 0);
debug_assert!(libc::memcmp(match_2.cast(), ip.cast(), matchLength) == 0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert in the zstd C code really means a rust debug_assert.

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/compress/zstd_opt.rs 0.00% 1 Missing ⚠️
Flag Coverage Δ
test-aarch64-apple-darwin 32.93% <0.00%> (-0.03%) ⬇️
test-aarch64-unknown-linux-gnu 31.67% <0.00%> (-0.02%) ⬇️
test-i686-unknown-linux-gnu 31.73% <0.00%> (-0.02%) ⬇️
test-x86_64-unknown-linux-gnu 33.36% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/compress/zstd_opt.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@folkertdev folkertdev merged commit 1035ad4 into main Jan 19, 2026
18 of 19 checks passed
@michielp1807 michielp1807 deleted the zstd-compress-benchmark branch January 20, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants