Draft
Conversation
- remove the Homebar variant and replace it with AlwaysOnlyIcon - remove the `with_alignment` builder [no changelog]
- a different design will be used, not with the shadow [no changelog]
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3B1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3W1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
Latest CI run: 22583244082
[no changelog]
- without this diff, due to the grace period, the connection icon does not disappear immediately after the USB is disconnected
- the label is now shown 'on tap' if a custom background image is set
- cache the rendering data in `FuelGauge::event` and `HomescreenStatus::event` and `render_connection_indicator` - also fix a small misalignment in HomescreenStatus label [no changelog]
- const what can be const - rename variables - improve commentary [no changelog]
- this should improve rendering speed by a bit which tips us to a higher framerate area (rendering time < 32ms) in a Homescreen with custom background - let's see if the quality is noticeable
obrusvit
force-pushed
the
obrusvit/eckhart/hs-improvements
branch
from
3873862 to
a712f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the Eckhart UI (TS7) according to #6501
if (ble::connected() || usb::connected())usb::is_connected#6502In order to speed up the rendering a little bit, the granularity of gradients on all ActionBar buttons was increased from 1 to 2. Let's see if it has any meaningful impact on the visual aspects.