Fix AIP boolean assertion for Ansible 12 jinja2_native mode

[dguido]

Summary

• Fix assert.that clause in AIP task that fails with Ansible 12+ due to jinja2_native mode
• The ansible.utils.ipv4 filter returns the IP string (not a boolean), which causes "Conditional result was derived from value of type 'str'" error
• Add | bool filter to convert the truthy string to a proper boolean

Fixes #14948

Test plan

• ansible-playbook main.yml --syntax-check passes
• ansible-lint roles/common/tasks/aip/main.yml passes (0 failures, 0 warnings)
• pytest tests/unit/ -q passes (91 tests)

🤖 Generated with Claude Code

[claude]

Code Review

Summary

This PR correctly fixes the Ansible 12+ jinja2_native mode compatibility issue in the AIP (Alternative Ingress IP) task. The change is minimal, targeted, and aligns with the project's documented best practices.

Positive Aspects

✅ Correct Fix for jinja2_native Mode: The addition of | bool follows the exact guidance in CLAUDE.md:

"Boolean conditionals require actual booleans" - The ansible.utils.ipv4 filter returns a string representation of the IP address (truthy) when valid, which Ansible 12+ rejects in conditionals.

✅ Minimal Change: Single line modification that solves exactly the issue reported in #14948 without introducing side effects.

✅ Quality Gates Passed: The PR description confirms all mandatory checks passed:

• ansible-playbook main.yml --syntax-check
• ansible-lint (0 failures, 0 warnings)
• pytest tests/unit/ (91 tests)

✅ Proper Parenthesization: Uses (snat_aipv4 | ansible.utils.ipv4) | bool to ensure correct filter order - validates IP first, then converts to boolean.

Technical Analysis

The fix addresses the core issue: ansible.utils.ipv4 returns the IP string itself when valid (e.g., "192.168.1.1"), or an empty string when invalid. In Ansible 11, this worked as a conditional because any truthy string was accepted. Ansible 12's jinja2_native mode requires explicit boolean types in assertions.

Filter Behavior:

• Valid IP: "192.168.1.1" | ansible.utils.ipv4 → "192.168.1.1" (truthy string)
• Invalid IP: "invalid" | ansible.utils.ipv4 → "" (empty string)
• With | bool: Converts truthy/falsy strings to proper booleans

Considerations

Test Coverage: The only usage of ansible.utils.ipv4 in the codebase is this specific line, so no other locations need updating. However, consider whether a unit test could verify this assertion doesn't regress with future Ansible versions. Current test suite passes, but direct AIP functionality testing appears limited.

Documentation: The error message is clear and actionable: "The SNAT IPv4 address not found. Cannot proceed with the alternative ingress ip."

Recommendation

Approve and merge. This is a clean fix that follows project standards and solves a real compatibility issue blocking DigitalOcean deployments with Ansible 12+.

Additional Notes

Verified against CLAUDE.md section on Jinja2 Native Mode (lines 163-187), which explicitly covers this pattern. The fix is idiomatic and future-proof.

[dguido]

Closing in favor of #14949 which uses the more correct approach: using the is ansible.utils.ipv4_address test (returns native boolean) rather than my filter + | bool workaround. Their | trim also handles potential whitespace from the metadata endpoint.