Conversation
rjollos
left a comment
rjollos
left a comment
There was a problem hiding this comment.
Looks good aside from the minor things I noted. If we can remove the commented code too, I think it's close to ready to merge.
| import pkg_resources | ||
|
|
||
| pkg_resources.require('Trac >= 1.0') | ||
| pkg_resources.require('Trac >= 1.3') |
There was a problem hiding this comment.
The changes you made should be compatible with 1.2 as well. Could we set this to 1.2?
| from genshi.filters import Transformer | ||
|
|
||
| from trac.web.chrome import web_context | ||
|
|
There was a problem hiding this comment.
I'd move this into the from trac.* block of imports.
| def __init__(self, target, time, author, comment=None): | ||
|
|
||
| super(TicketChangeEvent, self).__init__('ticket', 'reminder', target, | ||
| time, author) |
There was a problem hiding this comment.
This class may not be necessary. TicketChangeEvent has a 6th arg comment. Can TicketChangeEvent be used instead?
|
I may have been a bit premature. Still testing on our system. Found one issue already. Will know more tomorrow. I subclassed TicketChangeEvent as I thought perhaps a reminder needed some extra info e.g. age (not added yet) |
|
I think I've found the cause of the problem. Not sure what to do to fix it. |
You'll need to implement an
Let me know if you have any questions. Some aspects of implementing |
2 participants
I think this creates support for trac 1.4, or at least it seems to be working for us. Not sure I used the correct trac API methods though and I'm fairly sure there is more that needs updating. (I'm not familiar with trac APIs)