-
Notifications
You must be signed in to change notification settings - Fork 6
migrate: gitea-dev #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
migrate: gitea-dev #1181
Conversation
DiffNo diff detected! |
b674132 to
e5c0094
Compare
gitea-dev/deployment.yaml
Outdated
| containers: | ||
| - env: | ||
| - name: USER_GID | ||
| value: "996" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1002が正しいようです。該当箇所
| value: "996" | |
| value: "1002" |
gitea-dev/deployment.yaml
Outdated
| ports: | ||
| - containerPort: 3000 | ||
| protocol: TCP | ||
| - containerPort: 2200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2222番が正しいです
また、IngressはL7ロードバランサーで、http/httpsしかルーティングできないので、こういう書き方をしてホストのポートに直接アタッチする必要があります。
| - containerPort: 2200 | |
| - containerPort: 2222 | |
| hostPort: 2222 |
gitea-dev/config/app.ini
Outdated
| SSH_PORT = 2200 | ||
| SSH_LISTEN_PORT = 2200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devは2222が正しいです
| SSH_PORT = 2200 | |
| SSH_LISTEN_PORT = 2200 | |
| SSH_PORT = 2222 | |
| SSH_LISTEN_PORT = 2222 |
gitea-dev/service.yaml
Outdated
| - name: "2200" | ||
| port: 2200 | ||
| targetPort: 2200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここは必要ないです
| - name: "2200" | |
| port: 2200 | |
| targetPort: 2200 |
gitea-dev/ingress-route.yaml
Outdated
| - kind: Rule | ||
| match: Host(`git-dev.trapti.tech`) | ||
| services: | ||
| - name: gitea-dev | ||
| port: 2200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここは必要ないです
gitea-dev/deployment.yaml
Outdated
| kind: Deployment | ||
| metadata: | ||
| labels: | ||
| app: gitea-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この辺の名前から -dev を削除して欲しいです。(本番環境との設定との差異は内容だけにしたいため)
| app: gitea-dev | |
| app: gitea |
gitea-dev/config/app.ini
Outdated
| REPOSITORY_AVATAR_UPLOAD_PATH = /data/gitea/repo-avatars | ||
|
|
||
| [attachment] | ||
| PATH = /data/gitea/attachments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここはS3に投げてるみたいです
| PATH = /data/gitea/attachments | |
| STORAGE_TYPE = minio |
gitea-dev/secrets/gitea-dev.yaml
Outdated
| GITEA__lfs__MINIO_ACCESS_KEY_ID: ENC[AES256_GCM,data:JhkdKHZsI3BPhVVNZo2WPL0Hqqg=,iv:izcJl5Y465qys/ujRTzHr7Xzoi+XzL3MNVscQ2y3AMY=,tag:hLdo4ZpeEwg9ECJj3cXPcw==,type:str] | ||
| GITEA__lfs__MINIO_SECRET_ACCESS_KEY: ENC[AES256_GCM,data:AAyFxipxE3fk3QJ8hbLLw9RBHg4Yy0Z0vZsKF9jJaiUQOVTu//pREg==,iv:gU1/eUj8ugWjvPZvncNCtoPfsC+USwSfFOVvZrkPUdQ=,tag:6dXKZ5+EQ+mCXxnI/VwfGw==,type:str] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これは[storage.minio]セクションにあるべきです。環境変数だとどうなるのか調べたところ、GITEA__storage_0X2E_minio__MINIO_ACCESS_KEY_IDと書くらしいです。わかりにくい...😢
Secretのファイルを編集したあとは再暗号化をお願いします🙏
abf1a42 to
e5c0094
Compare
3b1abd9 to
9c6fcca
Compare
9c6fcca to
dce4f9a
Compare
| - kind: Rule | ||
| match: Host(`git-dev.trapti.tech`) | ||
| services: | ||
| - name: gitea | ||
| port: 2222 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここはIngressを通らないので必要なさそうです
| - kind: Rule | |
| match: Host(`git-dev.trapti.tech`) | |
| services: | |
| - name: gitea | |
| port: 2222 |
|
|
||
| [repository.upload] | ||
| TEMP_PATH = /data/gitea/uploads | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[repository.signing]が抜けてる気がします
| [database] | ||
| PATH = /data/gitea/gitea.db | ||
| DB_TYPE = mysql | ||
| HOST = private.kmbk.tokyotech.org:33060 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tailscaleになってなさそうです
| HOST = private.kmbk.tokyotech.org:33060 | |
| HOST = tailscale.kmbk.tokyotech.org:33060 |
| volumeMounts: | ||
| - name: storage | ||
| mountPath: /data | ||
| - name: config | ||
| mountPath: /app.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
何故か開発環境にはなかったけど、timezoneをホストと合わせるのが良い気がします 該当箇所
| @@ -0,0 +1,29 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
現在Secretに関する新ルールのPRが作成中なので、それに合わせてファイル名をsecrets.enc.yamlに変更していただけると助かります🙏
ファイル名の変更時は最暗号化は必要ないです
app.iniにどうやって認証情報埋め込めばいいのかわからない