Open
Conversation
TaeZStkyoht
force-pushed
the
fix-memory-leak
branch
4 times, most recently
from
d8fa737 to
1f35b76
Compare
kalvdans
approved these changes
Apr 4, 2025
Member
|
You have four different tasks that were mentioned in the commit message, one for each of the list items. I think this should be broken up into four commits instead of one, so please break this up into four commits. |
TaeZStkyoht
force-pushed
the
fix-memory-leak
branch
from
1f35b76 to
c73fa72
Compare
- BIGNUM must be freed both on tpm2tss_tpm2data_write and tpm2tss_tpm2data_read: definitely lost: 24 bytes in 1 blocks indirectly lost: 8 bytes in 1 blocks Signed-off-by: Oguzhan Turk <stkyoht@hotmail.com>
- TSSPRIVKEY's parent, privkey and pubkey members don't need to be allocated explicitly, because TSSPRIVKEY_new already does: definitely lost: 72 bytes in 3 blocks indirectly lost: 0 bytes in 0 blocks Signed-off-by: Oguzhan Turk <stkyoht@hotmail.com>
- TPM2_DATA* returned from RSA_get_app_data can be returned directly genkey_rsa() because RSA_free() doesn't free this item: definitely lost: 2,248 bytes in 1 blocks indirectly lost: 0 bytes in 0 blocks Signed-off-by: Oguzhan Turk <stkyoht@hotmail.com>
Signed-off-by: Oguzhan Turk <stkyoht@hotmail.com>
TaeZStkyoht
force-pushed
the
fix-memory-leak
branch
from
c73fa72 to
2843f9d
Compare
Author
done |
williamcroberts
approved these changes
Mar 3, 2026
kalvdans
approved these changes
Mar 3, 2026
Author
|
I don't know about those errors on pipelines. |
Member
I don't think it's you, I need to fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
definitely lost: 24 bytes in 1 blocks
indirectly lost: 8 bytes in 1 blocks
definitely lost: 72 bytes in 3 blocks
indirectly lost: 0 bytes in 0 blocks
definitely lost: 2,248 bytes in 1 blocks
indirectly lost: 0 bytes in 0 blocks