implement unlink io-uring call to implement remove_file and remove_dir#7799
Open
vrtgs wants to merge 1 commit intotokio-rs:masterfrom
Open
implement unlink io-uring call to implement remove_file and remove_dir#7799vrtgs wants to merge 1 commit intotokio-rs:masterfrom
vrtgs wants to merge 1 commit intotokio-rs:masterfrom
Conversation
ADD-SP
added
the
S-waiting-on-author
Daksh14
reviewed
Dec 29, 2025
tokio/src/io/uring/unlink.rs
Outdated
|
|
||
| impl Op<Unlink> { | ||
| /// Submit a request to open a file. | ||
| pub(crate) fn unlink(path: &Path, directory: bool) -> io::Result<Op<Unlink>> { |
Contributor
There was a problem hiding this comment.
We can have remove_dir and remove_file and you can ask for flags in the argument, its not apparent what the directory bool is going to do
Daksh14
reviewed
Dec 29, 2025
Daksh14
requested changes
Dec 29, 2025
Contributor
Daksh14
left a comment
Daksh14
left a comment
There was a problem hiding this comment.
Thank you! Tests are welcome
martin-g
reviewed
Dec 30, 2025
vrtgs
force-pushed
the
io-uring-unlink
branch
2 times, most recently
from
eaa378c to
851dbfc
Compare
Contributor
Author
I would love to, but I have 0 clue how the testing is structured around here, I was digging around a little, and I couldn't figure it out at a glance, I have finals currently so I ask for your patience on this request |
ADD-SP
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement io-uring unlink.
note that we can't use this to implement remove_dir_all because there is no way to read directory entries uring io-uring and reading entries is a blocking operation