Merged
Conversation
k-yle
reviewed
Jul 4, 2025
Collaborator
k-yle
left a comment
k-yle
left a comment
There was a problem hiding this comment.
looks good, it'll be nice to simplify this. But I wonder if we should show a warning if somone upgrades to v11 and tries to use the -r flag, to make migration easier?
And I think we'll also need to update the README to remove -r
Owner
Author
|
That is a great idea to show the warning! And great catch on updating the README, thought I had already done that. |
toddbluhm
force-pushed
the
feat-combine-f-r-flags
branch
from
01396b6 to
abf4cca
Compare
k-yle
approved these changes
Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on some user feedback common sense, the
-rand-fflags are mutually exclused (can't be used at the same time), however they serve the same purpose, providing a custom file path.Simply our flags by only using the
-fflag to provide a custom path.Now, if you provide a
-eflag, the-fflag will assume you are pointing to a custom.rcfile location.Likewise if you use just
-fit will assume you are pointing to a custom.envfile path.Resolves #359 and #372