Apply fixes suggested by Clippy version nightly-2023-08-22.#510
Merged
jrvanwhy merged 1 commit intotock:masterfrom Aug 22, 2023
Merged
Apply fixes suggested by Clippy version nightly-2023-08-22.#510jrvanwhy merged 1 commit intotock:masterfrom
nightly-2023-08-22.#510jrvanwhy merged 1 commit intotock:masterfrom
Conversation
I'm preparing a toolchain update PR that will supercede tock#481. I'd prefer to avoid sending a large PR that mixes these style updates with important `unsafe` code, so I'm splitting the update into two PRs.
jrvanwhy
added
the
upkeep
lschuermann
reviewed
Aug 22, 2023
Comment on lines
-90
to
+91
| if (gpio as usize) < self.gpios.len() { | ||
| self.gpios[gpio as usize].set(None); | ||
| if let Some(state) = self.gpios.get(gpio) { | ||
| state.set(None); |
Member
There was a problem hiding this comment.
Pretty impressive that it's able to make these suggestions now.
Collaborator
Author
There was a problem hiding this comment.
Oh, I guess I should've called this "Fix Clippy warnings". I did that manually.
lschuermann
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm preparing a toolchain update PR that will supercede #481. I'd prefer to avoid sending a large PR that mixes these style updates with important
unsafecode, so I'm splitting the update into two PRs.