Skip to content

Use the rust-version field in Cargo.toml to set minimum Rust version #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bradjc wants to merge 1 commit into from
Closed

Use the rust-version field in Cargo.toml to set minimum Rust version #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ license = "Apache-2.0 OR MIT"
name = "libtock"
repository = "https://www.github.com/tock/libtock-rs"
version = "0.1.0"
# Minimum required Rust compiler version for libtock-rs.
# Aug 2023: Set to support `Result::is_ok_and()`.
rust-version = "1.70"
Copy link
Copy Markdown
Collaborator

@jrvanwhy jrvanwhy Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set workspace-wide and inherited.

... which requires a newer nightly toolchain, because the current toolchain is too old to support workspace inheritance.

Copy link
Copy Markdown
Member

@lschuermann lschuermann Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like someone should really be looking into updating the nightly toolchain, eh? 😆
I can attempt that tonight, if adding sptr as an external dependency is uncontroversial enough. All of the other proposals in #481 (especially mine!) seem ... less than suboptimal.

Copy link
Copy Markdown
Collaborator

@jrvanwhy jrvanwhy Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test with this MSRV in Makefile rather than using +stable, otherwise this will bitrot.


[dependencies]
libtock_adc = { path = "apis/adc"}
Expand Down