Skip to content

snapshot(refactor[typing]): Improve type overrides with generics #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tony wants to merge 41 commits into
base: master
Choose a base branch
from

chore(mypy): drop now-unused type:ignore comments

331f275
Select commit
Loading
Failed to load commit list.
Draft

snapshot(refactor[typing]): Improve type overrides with generics #590

chore(mypy): drop now-unused type:ignore comments
331f275
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 10, 2026 in 0s

50.88% (+3.85%) compared to 3a6fb89

View this Pull Request on Codecov

50.88% (+3.85%) compared to 3a6fb89

Details

Codecov Report

❌ Patch coverage is 73.56115% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.88%. Comparing base (3a6fb89) to head (331f275).

Files with missing lines Patch % Lines
src/libtmux/snapshot/models/pane.py 51.38% 27 Missing and 8 partials ⚠️
src/libtmux/_internal/frozen_dataclass_sealable.py 78.62% 20 Missing and 8 partials ⚠️
src/libtmux/snapshot/utils.py 68.75% 19 Missing and 6 partials ⚠️
src/libtmux/snapshot/models/window.py 67.85% 11 Missing and 7 partials ⚠️
src/libtmux/snapshot/models/session.py 68.51% 11 Missing and 6 partials ⚠️
src/libtmux/snapshot/base.py 77.77% 10 Missing ⚠️
src/libtmux/snapshot/models/server.py 80.76% 9 Missing and 1 partial ⚠️
src/libtmux/_internal/frozen_dataclass.py 91.66% 1 Missing and 1 partial ⚠️
.../_internal/frozen_dataclass_sealable/test_basic.py 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   47.02%   50.88%   +3.85%     
==========================================
  Files          23       34      +11     
  Lines        3296     3852     +556     
  Branches      709      831     +122     
==========================================
+ Hits         1550     1960     +410     
- Misses       1384     1493     +109     
- Partials      362      399      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov