Allow overriding stamper config in core. Scope loginWithPasskey to certain passkeys#1158
Open
amircheikh wants to merge 1 commit intomainfrom
Open
Allow overriding stamper config in core. Scope loginWithPasskey to certain passkeys#1158amircheikh wants to merge 1 commit intomainfrom
loginWithPasskey to certain passkeys#1158amircheikh wants to merge 1 commit intomainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0458c8:
|
amircheikh
force-pushed
the
amir/stamper-override
branch
from
6d19717 to
e0458c8
Compare
ethankonk
reviewed
Dec 23, 2025
| * @returns A promise that resolves when the stamper and HTTP client have been updated. | ||
| * @throws {TurnkeyError} If there is an error initializing the new stamper. | ||
| */ | ||
| overrideApiKeyStamper = async ( |
Contributor
There was a problem hiding this comment.
I think this function should instead take a public key and an optional private key, and with those, override the stamper to use that key pair.
If a user just passes a public key, it uses it's associated private key in indexed db (not sure how that would work in practice), and if they pass both we use both (insanely insecure but maybe there is a niche use case for that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
It is now possible to recreate the stampers that are initialized by default in
@turnkey/core's core client.This allows you to dynamically swap out certain configurations during runtime without re-initializing the entire client.
This enables us to include an optional
allowedCredentialsarray in theloginWithPasskeyfunction as requestedDemo of this case:
Screen.Recording.2025-12-22.at.4.05.52.PM.mov
How I Tested These Changes
Locally in with-sdk-js demo
Did you add a changeset?
Will after reviews.
Open question
In
@turnkey/react-wallet-kit, should we automatically run this new function whenever we detect changes to theTurnkeyProviderconfig for the specific stamper? Right now, modifying thepasskeyConfigandwalletConfigin theTurnkeyProviderat runtime does not dynamically update it!