Skip to content

Conversation

@emostov
Copy link
Contributor

@emostov emostov commented Jan 23, 2026

Summary & Motivation (Problem vs. Solution)

This PR adds proto schemas and type generation, but does not modify any existing code

  • Adds new qos_proto crate with protobuf definitions
  • Contains .proto files for all protocol types (manifest, genesis, protocol messages, etc.)
  • To minimize dep review, I chose to try and match the new deps up as closely as possible with our mono repo. This effectively means zero new dep review required
  • Serde support for serializing all bytes to hex - this required me to add a custom serializer for Option<Vec<u8>> to get complete coverage

@emostov emostov requested review from a team as code owners January 23, 2026 20:18
@socket-security
Copy link

socket-security bot commented Jan 23, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedprotobuf-src@​1.1.0%2B21.57010010010070
Addedserde@​1.0.2288110093100100
Addedprost@​0.11.910010093100100
Addedtonic-build@​0.9.29910093100100

View full report

@emostov emostov changed the title Add qos_proto crate with protocol buffer types Add qos_proto crate with protocol buffer types 1/5 Jan 23, 2026
@emostov emostov force-pushed the zeke/proto-pr1-add-qos-proto branch 3 times, most recently from 36f16f9 to 46968bc Compare January 23, 2026 21:52
@emostov emostov force-pushed the zeke/proto-pr1-add-qos-proto branch from 46968bc to f1d3f10 Compare January 23, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants