Add QOS Key V1 secret format specification 2/3 #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
force-pushed
the
zeke/key-spec
branch
from
f03f61e to
84760c5
Compare
emostov
force-pushed
the
zeke/key-spec-2
branch
2 times, most recently
from
825d505 to
7cd8ff0
Compare
emostov
changed the title
emostov
force-pushed
the
zeke/key-spec
branch
from
301f697 to
81edfc7
Compare
emostov
force-pushed
the
zeke/key-spec-2
branch
2 times, most recently
from
4003203 to
05d5a9d
Compare
emostov
commented
Jan 25, 2026
| ``` | ||
| ┌─────────┬───────────────────┬───────────────────┬──────────────--------┐ | ||
| │ version │ hpke_public │ sign_public │ aes_gcm_256_key_id │ | ||
| │ 1 byte │ 65 bytes (SEC1) │ 65 bytes (SEC1) │ 32 bytes │ |
Contributor
Author
There was a problem hiding this comment.
I was debating making these compressed for readability, but it introduced a decompression bug vector for clients and we can use the fingerprint for anytime readability is an issue
emostov
force-pushed
the
zeke/key-spec-2
branch
from
05d5a9d to
222ea8b
Compare
emostov
force-pushed
the
zeke/key-spec-2
branch
from
222ea8b to
1edb714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
Spec updates for versioned quorum key secrets
Builds on #598
#611 builds on this