Skip to content

Conversation

@emostov
Copy link
Contributor

@emostov emostov commented Jan 12, 2026

Summary & Motivation (Problem vs. Solution)

  • Changes QosHash trait from borsh-based to proto-based hashing
  • Removes blanket implementation for all BorshSerialize types
  • Adds specific implementations for Manifest, GenesisOutput, and QuorumMember
  • All signature creation/verification now uses proto-encoded bytes for hashing

@emostov emostov changed the title Use proto encoding for signature hashing (QosHash) Use proto encoding for signature hashing (QosHash) 5/5 Jan 12, 2026
@emostov emostov force-pushed the zeke/proto-pr5-proto-signatures branch from 07a0865 to 6422fc3 Compare January 12, 2026 16:39
@emostov emostov force-pushed the zeke/proto-pr4-use-proto-msg branch 2 times, most recently from 602eac4 to 5b63e94 Compare January 12, 2026 16:41
@emostov emostov force-pushed the zeke/proto-pr5-proto-signatures branch 2 times, most recently from 29e2ea8 to c3d558d Compare January 12, 2026 17:13
@emostov emostov force-pushed the zeke/proto-pr5-proto-signatures branch from c3d558d to fdc9f2a Compare January 19, 2026 21:35
@emostov emostov force-pushed the zeke/proto-pr4-use-proto-msg branch from 67eae42 to 76ed9a0 Compare January 19, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants