Open
Conversation
Refactored ArtnetOutput and SacnOutput to use zero-allocation, pooled FrameData structures and lock-minimized, thread-safe communication between main and sender threads. Added per-universe sequence numbers, improved Art-Net 4 routing, and robust socket/connection management. Enhanced error handling, auto-reconnect, and UI/network adapter selection. Results in lower CPU usage, higher reliability, and better scalability for high-frequency DMX/sACN output.
Consolidated using directives and removed redundant code in both ArtnetOutput.cs and SacnOutput.cs. Removed PrintToLog input and related logic from SacnOutput. Reformatted ICustomDropdownHolder methods for readability. No changes to core logic or functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update focusing on the dmx output optimalizations.