Skip to content

Update: Parameter's tooltip appears even if animated or has input connected #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pixtur merged 2 commits into from
Mar 11, 2026
Merged

Update: Parameter's tooltip appears even if animated or has input connected #975

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edf45b0
Update: Parameters tooltip even if animated or input connected
newemka Mar 8, 2026
e05c7a2
Tooltip when input has connection
newemka Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 41 additions & 28 deletions Editor/UiModel/InputsAndTypes/InputValueUi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,13 +230,13 @@ InputEditStateFlags DrawConnectedParameter()
ImGui.PushStyleColor(ImGuiCol.Text, UiColors.ForegroundFull.Rgba);
ImGui.Button($"{input.Name.AddSpacesForImGuiOutput()}##ParamName", new Vector2(ParameterNameWidth, 0.0f));
ImGui.PopStyleColor();
if (ImGui.BeginPopupContextItem("##parameterOptions", 0))
/*if (ImGui.BeginPopupContextItem("##parameterOptions", 0))
{
if (ImGui.MenuItem("Parameters settings"))
editState = InputEditStateFlags.ShowOptions;

ImGui.EndPopup();
}
}*/

CustomComponents.ContextMenuForItem(() =>
{
Expand Down Expand Up @@ -280,6 +280,7 @@ InputEditStateFlags DrawConnectedParameter()

if (ImGui.MenuItem("Parameters settings"))
editState = InputEditStateFlags.ShowOptions;

});

ImGui.PopStyleVar();
Expand All @@ -288,14 +289,23 @@ InputEditStateFlags DrawConnectedParameter()
ImGui.PushItemWidth(200.0f);
ImGui.SetNextItemWidth(-1);

string connectedName;
if (typedInputSlot.TryGetFirstConnection(out var connectedSlot))
var connectedName = "???";
if (typedInputSlot.TryGetFirstConnection(out var connectedSlot) && connectedSlot?.Parent != null)
{
connectedName = connectedSlot?.Parent.Symbol.Name ?? "???";
connectedName = !string.IsNullOrWhiteSpace(connectedSlot.Parent.SymbolChild.Name)
? connectedSlot.Parent.SymbolChild.Name
: (!string.IsNullOrWhiteSpace(connectedSlot.Parent.Symbol.Name)
? connectedSlot.Parent.Symbol.Name
: "???");
}
else
if (ImGui.IsItemHovered())
{
connectedName = "???";
var text = "Input: " + connectedName ;
if (!string.IsNullOrEmpty(Description))
{
text += "\n-----";
}
CustomComponents.TooltipForLastItem(text, Description);
}

ImGui.PushStyleColor(ImGuiCol.Text, typeColor.Rgba);
Expand Down Expand Up @@ -398,8 +408,7 @@ InputEditStateFlags DrawAnimatedParameter(Curve curve)
});
ImGui.PopStyleVar();

if (ImGui.IsItemHovered())
Icons.DrawIconAtScreenPosition(Icon.Revert, ImGui.GetItemRectMin() + new Vector2(6, 4) * T3Ui.UiScaleFactor);
DrawInputTooltipAndResetIcon(input);

if (isClicked)
{
Expand Down Expand Up @@ -452,25 +461,7 @@ InputEditStateFlags DrawNormalParameter()
ImGui.PopStyleColor(hasStyleCount);
}

if (ImGui.IsItemHovered())
{
var text = "";
if (!string.IsNullOrEmpty(Description))
{
text += Description;
}

var additionalNotes = input.IsDefault ? null : "Click to reset to default";

if (!string.IsNullOrEmpty(text) || !string.IsNullOrEmpty(additionalNotes))
{
CustomComponents.TooltipForLastItem(text,
additionalNotes);
}

if (!input.IsDefault)
Icons.DrawIconAtScreenPosition(Icon.Revert, ImGui.GetItemRectMin() + new Vector2(6, 4) * T3Ui.UiScaleFactor);
}
DrawInputTooltipAndResetIcon(input);

if (isClicked)
{
Expand Down Expand Up @@ -606,6 +597,28 @@ public virtual void Read(JToken? inputToken)
public Type Type { get; } = typeof(T);

private const Relevancy DefaultRelevancy = Relevancy.Optional;

private void DrawInputTooltipAndResetIcon(Symbol.Child.Input input)
{
if (!ImGui.IsItemHovered())
return;

var text = Description ?? string.Empty;
var additionalNotes = input.IsDefault ? null : "Click to reset to default";

if (!string.IsNullOrEmpty(text) || !string.IsNullOrEmpty(additionalNotes))
{
CustomComponents.TooltipForLastItem(text, additionalNotes);
}

if (!input.IsDefault)
{
Icons.DrawIconAtScreenPosition(
Icon.Revert,
ImGui.GetItemRectMin() + new Vector2(6, 4) * T3Ui.UiScaleFactor
);
}
}
}

internal static class InputArea
Expand Down
Loading