Conversation
feature:dockerfileForArchitecture
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…e cross-site scripting' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
TheMrSheldon
requested changes
Apr 21, 2026
| from unittest.mock import Mock, patch | ||
|
|
||
| os.environ["TIRA_WORKER_CONFIG"] = os.path.abspath( | ||
| os.path.join(os.path.dirname(__file__), "..", "tira-worker-config.yml") |
Member
There was a problem hiding this comment.
This would be better to enter in https://github.com/tira-io/tira/blob/main/application/pyproject.toml#L33-L43
| try: | ||
| job = RunningProcesses.objects.get(uuid=job_id) | ||
| except: | ||
| return HttpResponseServerError(json.dumps({"status": 1, "message": "Job does not exist."})) |
Member
There was a problem hiding this comment.
HttpResponseNotFound would be better suited
| @check_conditional_permissions(restricted=True) | ||
| def update_running_process_output(request: Request, vm_id: str, job_id: str) -> Response: | ||
| if request.method != "POST": | ||
| return HttpResponseServerError(json.dumps({"status": 1, "message": "Only Post allowed."})) |
Member
There was a problem hiding this comment.
HttpResponseBadRequest would be better suited
| try: | ||
| data = json.loads(request.body) if request.body else request.POST.dict() | ||
| except json.JSONDecodeError: | ||
| return HttpResponseServerError(json.dumps({"status": 1, "message": "Could not parse request body as JSON."})) |
Member
There was a problem hiding this comment.
HttpResponseBadRequest would be better suited
| return HttpResponseServerError(json.dumps({"status": 1, "message": "Could not parse request body as JSON."})) | ||
|
|
||
| if "output" not in data: | ||
| return HttpResponseServerError(json.dumps({"status": 1, "message": "A field output is expected."})) |
Member
There was a problem hiding this comment.
HttpResponseBadRequest would be better suited
| def verify_image(self, image, platform): | ||
| client = self.__docker_client() | ||
| inspect_result = client.api.inspect_image(image) | ||
| allowed = set([platform]) |
Member
There was a problem hiding this comment.
Suggested change
| allowed = set([platform]) | |
| allowed ={platform,} |
| client = self.__docker_client() | ||
| inspect_result = client.api.inspect_image(image) | ||
| allowed = set([platform]) | ||
| architecture = "unknow" |
Member
There was a problem hiding this comment.
Maybe this could be a constant: ARCH_UNKNOWN so that people can compare against it
| } | ||
|
|
||
| if mount_directory: | ||
| additional_paths = 0 |
| if mount_directory: | ||
| additional_paths = 0 | ||
| for k, v in mount_directory.items(): | ||
| target_dir = "/tira-data/mounted/{additional_paths}" |
Member
There was a problem hiding this comment.
Bug: Missing f before the string: f"/tira-data/mounted/{additional_paths}"?
Comment on lines
+529
to
+534
| additional_paths = 0 | ||
| for k, v in mount_directory.items(): | ||
| target_dir = "/tira-data/mounted/{additional_paths}" | ||
| additional_paths += 1 | ||
| volumes[v] = {"bind": target_dir, "mode": "ro"} | ||
| environment[k] = target_dir |
Member
There was a problem hiding this comment.
Suggested change
| additional_paths = 0 | |
| for k, v in mount_directory.items(): | |
| target_dir = "/tira-data/mounted/{additional_paths}" | |
| additional_paths += 1 | |
| volumes[v] = {"bind": target_dir, "mode": "ro"} | |
| environment[k] = target_dir | |
| for i, (k, v) in enumerate(mount_directory.items()): | |
| target_dir = f"/tira-data/mounted/{i}" | |
| volumes[v] = {"bind": target_dir, "mode": "ro"} | |
| environment[k] = target_dir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.