-
Notifications
You must be signed in to change notification settings - Fork 0
docs(runners): remove stale bates-*/rocky8/rocky9 references #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a05590a
b22c426
d337fb0
3b69806
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,14 +100,14 @@ test-dind: | |
| - docker pull alpine:latest | ||
| - docker images | ||
|
|
||
| test-rocky8: | ||
| tags: [rocky8] | ||
| test-tinyland-docker: | ||
| tags: [tinyland-docker] | ||
| script: | ||
| - cat /etc/redhat-release | ||
| - dnf list installed | head -20 | ||
|
|
||
| test-rocky9: | ||
| tags: [rocky9] | ||
| test-tinyland-nix: | ||
| tags: [tinyland-nix] | ||
| script: | ||
| - cat /etc/redhat-release | ||
| - dnf list installed | head -20 | ||
|
Comment on lines
+103
to
113
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Both |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,8 +12,8 @@ The legacy setup required operators to: | |
| ``` | ||
| TF_VAR_docker_runner_token=glrt-... | ||
| TF_VAR_dind_runner_token=glrt-... | ||
| TF_VAR_rocky8_runner_token=glrt-... | ||
| TF_VAR_rocky9_runner_token=glrt-... | ||
| TF_VAR_tinyland-docker_runner_token=glrt-... | ||
| TF_VAR_tinyland-nix_runner_token=glrt-... | ||
|
Comment on lines
+15
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new names If the underlying Terraform variable names actually use hyphens, they need to be set via a |
||
| TF_VAR_nix_runner_token=glrt-... | ||
| ``` | ||
| 3. Rotate tokens manually when they expired or were revoked. | ||
|
|
@@ -130,8 +130,8 @@ include: | |
| | ------------------------------- | -------------- | | ||
| | `ci-templates/docker.yml` | `docker-job` | | ||
| | `ci-templates/dind.yml` | `dind-job` | | ||
| | `ci-templates/rocky8.yml` | `rocky8-job` | | ||
| | `ci-templates/rocky9.yml` | `rocky9-job` | | ||
| | `ci-templates/tinyland-docker.yml` | `tinyland-docker-job` | | ||
| | `ci-templates/tinyland-nix.yml` | `tinyland-nix-job` | | ||
| | `ci-templates/nix.yml` | `nix-job` | | ||
| | `ci-templates/docker-build.yml` | `docker-build` | | ||
| | `ci-templates/k8s-deploy.yml` | `k8s-deploy` | | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -36,8 +36,8 @@ syntax instead of writing jobs from scratch. | |||||||||
| | -------------- | ------------------------------------- | | ||||||||||
| | `docker-job` | Standard Docker runner job | | ||||||||||
| | `dind-job` | Docker-in-Docker job | | ||||||||||
| | `rocky8-job` | Rocky 8 runner job | | ||||||||||
| | `rocky9-job` | Rocky 9 runner job | | ||||||||||
| | `tinyland-docker-job` | Rocky 8 runner job | | ||||||||||
| | `tinyland-nix-job` | Rocky 9 runner job | | ||||||||||
|
Comment on lines
+39
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The component descriptions still reference the old runner names.
Suggested change
|
||||||||||
| | `nix-job` | Nix runner job with Attic cache | | ||||||||||
| | `docker-build` | Build and push container images | | ||||||||||
| | `k8s-deploy` | Deploy to Kubernetes via GitLab Agent | | ||||||||||
|
|
@@ -142,7 +142,7 @@ Each job runs in an ephemeral `ci-job-*` Kubernetes namespace with: | |||||||||
| - **LimitRange**: sensible container defaults | ||||||||||
| - **RBAC**: read-only access to pods, deployments, HPAs, jobs, events | ||||||||||
|
|
||||||||||
| This applies to `docker`, `rocky8`, `rocky9`, and `nix` runners. The `dind` | ||||||||||
| This applies to `docker`, `tinyland-docker`, `tinyland-nix`, and `nix` runners. The `dind` | ||||||||||
| runner is the exception -- it uses a shared namespace with privileged access. | ||||||||||
| See [security-model.md](security-model.md) for full details. | ||||||||||
|
|
||||||||||
|
|
@@ -159,7 +159,7 @@ gitlab.com but not github.com), this causes failures when jobs try to clone | |||||||||
| from GitHub. | ||||||||||
|
|
||||||||||
| **Rule of thumb:** self-hosted runners should only be tagged with their | ||||||||||
| workload type (`docker`, `nix`, `rocky8`, etc). Projects request specific | ||||||||||
| workload type (`docker`, `nix`, `tinyland-docker`, etc). Projects request specific | ||||||||||
| runners by matching these workload tags. Generic infrastructure jobs stay on | ||||||||||
| SaaS shared runners. | ||||||||||
|
|
||||||||||
|
|
||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,20 @@ | ||
| # GitLab Managed Terraform State | ||
| # RustFS S3-compatible state backend | ||
| # | ||
| # State is stored in GitLab's built-in Terraform state management. | ||
| # Access via CI_JOB_TOKEN in pipelines. | ||
| # State stored in RustFS (on-cluster MinIO-compatible store in nix-cache namespace). | ||
| # In-cluster runners access via: http://attic-rustfs-hl.nix-cache.svc:9000 | ||
| # Local dev: kubectl port-forward -n nix-cache svc/attic-rustfs 9000:9000 | ||
| # then: tofu init -backend-config="endpoint=http://localhost:9000" -backend-config="access_key=..." -backend-config="secret_key=..." | ||
|
|
||
| terraform { | ||
| backend "http" {} | ||
| backend "s3" { | ||
| bucket = "tofu-state" | ||
| key = "arc-runners/terraform.tfstate" | ||
| region = "us-east-1" | ||
| endpoint = "http://attic-rustfs-hl.nix-cache.svc:9000" | ||
| skip_credentials_validation = true | ||
| skip_metadata_api_check = true | ||
| skip_requesting_account_id = true | ||
| skip_s3_checksum = true | ||
| use_path_style = true | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,33 @@ | ||
| # Attic Stack - Backend Configuration | ||
| # | ||
| # Uses GitLab Managed Terraform State for state storage and locking. | ||
| # This enables collaboration and state versioning through GitLab. | ||
| # Uses RustFS S3-compatible state backend (on-cluster MinIO-compatible store). | ||
| # | ||
| # Backend Configuration Methods: | ||
| # | ||
| # 1. CI/CD (automatic): | ||
| # Environment variables are set by .gitlab-ci.yml templates: | ||
| # TF_HTTP_ADDRESS, TF_HTTP_LOCK_ADDRESS, TF_HTTP_UNLOCK_ADDRESS | ||
| # TF_HTTP_USERNAME (gitlab-ci-token), TF_HTTP_PASSWORD (CI_JOB_TOKEN) | ||
| # 1. CI/CD (ARC runners, in-cluster): | ||
| # Endpoint in backend block points to cluster-internal DNS. | ||
| # Credentials passed via -backend-config or env vars: | ||
| # -backend-config="access_key=..." -backend-config="secret_key=..." | ||
| # | ||
| # 2. Local development with GitLab state: | ||
| # Use Justfile commands which configure backend via -backend-config: | ||
| # just init # Initialize with GitLab backend | ||
| # just plan # Plan changes | ||
| # just apply # Apply changes | ||
| # | ||
| # Or manually: | ||
| # export TF_HTTP_PASSWORD="glpat-your-token" | ||
| # tofu init -backend-config=backend.local.hcl | ||
| # 2. Local development: | ||
| # Port-forward RustFS and override endpoint: | ||
| # kubectl port-forward -n nix-cache svc/attic-rustfs 9000:9000 | ||
| # tofu init -backend-config="endpoint=http://localhost:9000" \ | ||
| # -backend-config="access_key=..." -backend-config="secret_key=..." | ||
| # | ||
| # 3. Local-only state (not recommended for shared infrastructure): | ||
| # tofu init -backend=false | ||
| # # Uses in-memory state, changes are not persisted | ||
|
|
||
| terraform { | ||
| # HTTP backend for GitLab Managed Terraform State | ||
| # All configuration provided via environment variables or -backend-config | ||
| backend "http" { | ||
| # Required TF_HTTP_* environment variables: | ||
| # TF_HTTP_ADDRESS - State read/write URL | ||
| # TF_HTTP_LOCK_ADDRESS - Lock URL | ||
| # TF_HTTP_UNLOCK_ADDRESS - Unlock URL | ||
| # TF_HTTP_USERNAME - GitLab username or "gitlab-ci-token" | ||
| # TF_HTTP_PASSWORD - Personal access token or CI_JOB_TOKEN | ||
| # | ||
| # Optional: | ||
| # TF_HTTP_LOCK_METHOD - POST (default) | ||
| # TF_HTTP_UNLOCK_METHOD - DELETE (default) | ||
| # TF_HTTP_RETRY_WAIT_MIN - Retry wait time (default: 1s) | ||
| backend "s3" { | ||
| bucket = "tofu-state" | ||
| key = "attic/terraform.tfstate" | ||
| region = "us-east-1" | ||
| endpoint = "http://attic-rustfs-hl.nix-cache.svc:9000" | ||
| skip_credentials_validation = true | ||
| skip_metadata_api_check = true | ||
| skip_requesting_account_id = true | ||
| skip_s3_checksum = true | ||
| use_path_style = true | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,19 @@ | ||
| # GitLab Managed Terraform State | ||
| # RustFS S3-compatible state backend | ||
| # | ||
| # State is stored in GitLab's built-in Terraform state management. | ||
| # Access via CI_JOB_TOKEN in pipelines. | ||
| # State stored in RustFS (on-cluster MinIO-compatible store in nix-cache namespace). | ||
| # In-cluster runners: http://attic-rustfs-hl.nix-cache.svc:9000 | ||
| # Local dev: kubectl port-forward -n nix-cache svc/attic-rustfs 9000:9000 | ||
|
|
||
| terraform { | ||
| backend "http" {} | ||
| backend "s3" { | ||
| bucket = "tofu-state" | ||
| key = "gitlab-runners/terraform.tfstate" | ||
| region = "us-east-1" | ||
| endpoint = "http://attic-rustfs-hl.nix-cache.svc:9000" | ||
| skip_credentials_validation = true | ||
| skip_metadata_api_check = true | ||
| skip_requesting_account_id = true | ||
| skip_s3_checksum = true | ||
| use_path_style = true | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,19 @@ | ||
| # Backend Configuration | ||
| # RustFS S3-compatible state backend | ||
| # | ||
| # Uses GitLab managed Terraform state. | ||
| # Initialize with: just init | ||
| # State stored in RustFS (on-cluster MinIO-compatible store in nix-cache namespace). | ||
| # In-cluster runners: http://attic-rustfs-hl.nix-cache.svc:9000 | ||
| # Local dev: kubectl port-forward -n nix-cache svc/attic-rustfs 9000:9000 | ||
|
|
||
| terraform { | ||
| backend "http" {} | ||
| backend "s3" { | ||
| bucket = "tofu-state" | ||
| key = "runner-dashboard/terraform.tfstate" | ||
| region = "us-east-1" | ||
| endpoint = "http://attic-rustfs-hl.nix-cache.svc:9000" | ||
| skip_credentials_validation = true | ||
| skip_metadata_api_check = true | ||
| skip_requesting_account_id = true | ||
| skip_s3_checksum = true | ||
| use_path_style = true | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Install kubectlstep fetches the version dynamically fromstable.txtat runtime and does not verify the binary's checksum. This means:Consider pinning a specific version and verifying the checksum. This same pattern is duplicated in the
applyjob (~line 142) and both should be updated together.