fix: repo health cleanup — dead code, stale refs, CI hygiene#162
fix: repo health cleanup — dead code, stale refs, CI hygiene#162Jesssullivan merged 5 commits intomainfrom
Conversation
- scripts/test-abstraction.sh (141 LOC, unreferenced) - scripts/generate-attic-token.sh (142 LOC, unreferenced) - scripts/lib/config.sh (53 LOC, only used by dead test-abstraction) - nix/overlays/default.nix (46 LOC, never imported by flake.nix) - .github/workflows/test-arc-runners.yml (triggers on non-existent branch)
Bulk update 16 stale URL references across docs, flake.nix, BUILD.bazel, release workflow, and link checker config.
- Remove use_minio conditionals from plan/apply/drift CI jobs - Remove minio-operator debug checks and health checks - Remove ghost minio-operator/minio-tenant doc entries, add rustfs - Update Justfile and health-check.sh - Net ~74 LOC removed from CI alone
- Remove minioStorageUsed/minioObjectCount (MinIO replaced by RustFS) - Replace 8 hardcoded "attic-cache" strings with CACHE_NS env variable
- Pin trivy-action and trufflehog to release SHAs (supply-chain risk) - Add concurrency groups to validate, build-image, secrets-scan, deploy - Fix broken ./github/ → ./.github/ paths in custom actions
Greptile SummaryThis is a broad repo-health cleanup PR (-507 net LOC across 32 files) that removes dead MinIO CI logic, renames 16 stale Confidence Score: 3/5Two targeted fixes needed before merge: a broken The vast majority of changes are safe, mechanical cleanups. However the stale
Important Files Changed
Reviews (1): Last reviewed commit: "fix(ci): pin actions to SHA, add concurr..." | Re-trigger Greptile |
| git clone --branch ${{ github.ref_name }} https://github.com/Jesssullivan/attic-iac.git | ||
| git clone --branch ${{ github.ref_name }} https://github.com/tinyland-inc/GloriousFlywheel.git | ||
| cd attic-iac | ||
| cp config/organization.example.yaml config/organization.yaml |
There was a problem hiding this comment.
Stale directory name in install instructions
The clone URL was updated from Jesssullivan/attic-iac to tinyland-inc/GloriousFlywheel, but the cd attic-iac command on the following line was not updated. After running git clone https://github.com/tinyland-inc/GloriousFlywheel.git, the local directory will be named GloriousFlywheel, so cd attic-iac will fail for anyone following these release notes.
| cp config/organization.example.yaml config/organization.yaml | |
| cd GloriousFlywheel |
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
cancel-in-progress: true undermines secret detection coverage
Adding cancel-in-progress: true to the secrets-scan workflow creates a race condition: if two pushes arrive on the same branch in quick succession, the first scan is cancelled and the new one starts from the latest commit. Depending on how TruffleHog resolves its scan range, commits introduced by the cancelled run may never be fully scanned.
For availability workflows (build, deploy, validate) cancel-in-progress: true is the right trade-off, but for a security gate the cost of a cancelled run is higher than the cost of a redundant one. Consider setting it to false:
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: true | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: false |
| | tinyland-infra | 7.4.0 | Bzlmod | Aligned | | ||
| | tinyland-infra | inherited | local_path_override | Consumer | |
There was a problem hiding this comment.
Duplicate
tinyland-infra entry in version matrix
The two gf-overlay rows were collapsed into a single new tinyland-infra | 7.4.0 | Bzlmod | Aligned row, but an existing tinyland-infra | inherited | local_path_override | Consumer row was already in the table. The result is two tinyland-infra entries with conflicting attributes, which is ambiguous for readers. If these represent genuinely different repos/configurations they should have distinct names; if one entry should replace the other, the duplicate should be removed.
Summary
Jesssullivan/attic-iacURLs →tinyland-inc/GloriousFlywheeluse_minioconditionals, health checks, docs)trivy-actionandtrufflehogto release SHAs (supply-chain risk)./github/→./.github/)Commits
chore: remove dead code— 434 LOC of unused scripts, overlays, workflowfix: rename URLs— 16 stale Jesssullivan referencesfix(ci): remove dead MinIO logic— ~74 LOC from CI, update docs to RustFSfix(dashboard): remove MinIO queries— configurable namespacefix(ci): pin actions, concurrency, action paths— supply-chain + hygieneTest plan
bazel test //...passesnix flake checkpasses