Merged
Conversation
- BREAKING: Update `Color` API - BREAKING: Using CLI `sync` with a custom `--schemes-dir` is not supported anymore. `sync` only syncs to the default data-path schemes-dir - BREAKING: Remove list, listbase16 and listbase24 scheme systems in place of using the yaml template config `options.list` property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on this for a while and I was slowly creating the spec as I was creating the builder. https://github.com/tinted-theming/home/blob/main/specs/tinted8/builder.md. This PR doesn't fully match the spec, but I'm going to update the spec since I think this PR introduces good changes to the spec.
Added
tinted_builder::tinted8) withSchemetype and spec version constants (
SUPPORTED_BUILDER_SPEC_VERSION,SUPPORTED_STYLING_SPEC_VERSION).scheme,palette,ui,and
syntaxcontexts; color objects exposehex,hex-r/g/b,hex-bgr,rgb,rgb16, anddecfields.variants; derive
orange/brown; auto-generategraywhen missing).supports.tinted8-stylingandsupports.tinted8-builderintemplates/config.yaml.options.listwithschemesarray provided to mustache.specs/builder.mdandspecs/styling.mdreferences; expandREADMEs with Tinted8 usage and template variables.
Changed
Color::newnow takes(hex, Option<ColorName>, Option<ColorVariant>);Colorstruct gainednameandvariantfields. PassNonefor backward-compatible behavior.Also enhances color handling to accept 3‑digit hex, adds
hex-bgr, andprovides 16‑bit
rgb16plus normalizeddecchannel serialization.syncwith a custom--schemes-diris notsupported anymore.
synconly syncs to the default$XDG_DATA_DIR/tinted-theming/tinted-builder-rust/schemesdirectory.Templateto render Tinted8 schemes; update Base16/Base24code paths for consistency.
tinted8 compatibility.
Fixed
E300/E301/E302(missingsupportsentries),E303(missing mustache),E305(missing/invalid config),E400(no schemes), plusE110/E111forunknown systems/invalid files.
Removed
list,listbase16, andlistbase24schemesystems and their
SchemeSystemenum variants.SchemeSystem::from_strnolonger accepts these values. Use the yaml config
options.listflow for listgeneration instead.