Return bigint from compressed_data_column_size#9710
Open
Conversation
The function summed the byte size of every value in a compressed batch into an int32 accumulator and returned int32. A batch can hold up to 1000 rows, and for wide varlena columns (large text, jsonb, bytea) the sum can pass 2 GB, at which point the accumulator silently wraps and the function reports a wrong size. Switch the accumulator and return type to int64 so the full per-batch size is preserved. The SQL function signature changes from INTEGER to BIGINT, so the upgrade and downgrade scripts drop the function before the new version is created. The in-tree caller in size_utils.sql wraps the result in sum(), which keeps working unchanged. No regression test is added: triggering the overflow needs more than 2 GB of varlena data in a single batch, which is too resource intensive to run as part of the normal test suite.
|
@antekresic, @melihmutlu: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function summed the byte size of every value in a compressed batch
into an int32 accumulator and returned int32. A batch can hold up to
1000 rows, and for wide varlena columns (large text, jsonb, bytea) the
sum can pass 2 GB, at which point the accumulator silently wraps and
the function reports a wrong size.
Switch the accumulator and return type to int64 so the full per-batch
size is preserved. The SQL function signature changes from INTEGER to
BIGINT, so the upgrade and downgrade scripts drop the function before
the new version is created.
The in-tree caller in size_utils.sql wraps the result in sum(), which
keeps working unchanged.
No regression test is added: triggering the overflow needs more than
2 GB of varlena data in a single batch, which is too resource intensive
to run as part of the normal test suite.