Conversation
Reading the time bucket parameters of a continuous aggregate could read from a NULL pointer when the timezone or offset argument was a NULL constant, and could read past the end of the argument list when the function had fewer than two arguments. Skip the read when the constant is NULL, and check the number of arguments before accessing them.
|
@kpan2034, @natalya-aksman: please review this pull request.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading the time bucket parameters of a continuous aggregate could
read from a NULL pointer when the timezone or offset argument was a
NULL constant, and could read past the end of the argument list when
the function had fewer than two arguments. Skip the read when the
constant is NULL, and check the number of arguments before accessing
them.