Allow BatchSortedMerge with no segmentby or sorted on segmentbys pinned to Consts#9702
Open
natalya-aksman wants to merge 3 commits intotimescale:mainfrom
Open
Conversation
|
@antekresic, @dbeck: please review this pull request.
|
… add CL and recap unit tests
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
natalya-aksman
commented
Apr 30, 2026
| :PREFIX | ||
| SELECT * FROM test_segby ORDER BY time ASC NULLS LAST; | ||
|
|
||
| -- Should be optimized |
Member
Author
There was a problem hiding this comment.
Removed copy/paste added by mistake. Those are redundant tests.
Poroma-Banerjee
approved these changes
Apr 30, 2026
Member
|
Please dont abbreviate BatchSortedMerge to BSM in comments and descriptions |
Member
Author
Will change to full name. |
natalya-aksman
changed the title
…ed to Consts, use BatchSortedMerge instead of BSM
natalya-aksman
commented
May 1, 2026
| * If pathkeys still has items, but we didn't find all segmentby columns, | ||
| * we cannot satisfy these pathkeys by sorting the compressed chunk table. | ||
| */ | ||
| if (i != list_length(pathkeys) && |
Member
Author
There was a problem hiding this comment.
We rule out (i == list_length(pathkeys)) on :3045 above, so this check is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the easiest scenario for https://github.com/timescale/eng-database/issues/811: for unordered chunks, allow BatchSortedMerge for columnstores with no segmentby.
Also a trivial case when we sort on all (segmentby + orderby) when all segmentby columns are pinned to Consts, meaning we are sorting one segment only.
Some existing tests can use BatchSortedMerge now because of the above changes, those tests were recapped.