Open
Conversation
PeekableIO: buffer stores raw bytes in external encoding; maybe_transcode applies ext→int conversion on read-out. @buffer_frozen flag prevents premature delegation to @io before rewind, so all bytes consumed during auto-detection are replayable. each_char falls back to ASCII_8BIT (not UTF-8) for sources with no declared encoding. Reader: enforce_utf8_encoding was using force_encoding(utf-8) which silently dropped non-ASCII bytes from ISO-8859-1, Windows-1252, Shift-JIS and other encodings. Now uses line.encoding as the source in encode() for correct transcoding. Use Encoding::ASCII_8BIT consistently (Encoding::BINARY is an alias). Add comprehensive tests: multi-encoding unit tests, transcoding pair integration tests, non-seekable stream transcoding.
…andling, and full test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous versions of SmarterCSV required that we do a IO.rewind after automatic detection of row_sep and col_sep. This limits the use cases of the gem.
We also want to be able to use it for streaming input.
Work on this branch:
IO.rewindwhen doing auto-detectionThis adds a peekable IO buffer