feat: support of Hesai FT120 sensor#412
Open
mgiardino-be wants to merge 13 commits intotier4:mainfrom
Open
Conversation
…ion binary file. Added calibration file from a sensor.
Added definitions for message tail, data packet and FT120 sensor.
…tatus structure that can be reused (is the same as for AT128 and QT128 sensors). Integrated the sensor in the HW interface.
…tion for each pixel.
- it uses old ScanCutAngles approac (not a big deal due to limited FoV); - dual return works, but manual recommends to use only single return modes; - maybe a couple of "if" in unpack and convert_returns can be simplified; -mask filter was not tested.
Include the new sensor in the driver source, with the correct decoder selection.
mgiardino-be
changed the title
mgiardino-be
changed the title
Collaborator
|
@mgiardino-be Thank you for the PR, looks very good already! I will finish my review by end of this week. In the meantime, could you check and address the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
GitHub Issue 410
Description
Add support for Hesai FT120 solid state sensor.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks