Migrate MessageView Action Visbility Flags to PreferenceDataStore#10542
Open
shamim-emon wants to merge 5 commits intothunderbird:mainfrom
Open
Migrate MessageView Action Visbility Flags to PreferenceDataStore#10542shamim-emon wants to merge 5 commits intothunderbird:mainfrom
shamim-emon wants to merge 5 commits intothunderbird:mainfrom
Conversation
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
dani-zilla
reviewed
Feb 18, 2026
| menu.findItem(R.id.move).isVisible = K9.isMessageViewMoveActionVisible | ||
| menu.findItem(R.id.archive).isVisible = canMessageBeArchived && K9.isMessageViewArchiveActionVisible | ||
| menu.findItem(R.id.spam).isVisible = canMessageBeMovedToSpam && K9.isMessageViewSpamActionVisible | ||
| menu.findItem(R.id.move).isVisible = generalSettingsManager.getConfig().display |
Contributor
There was a problem hiding this comment.
Bit of a nitpick, but I do think this might look better broken up after the assignment operator, then a second time after the &&. Also, typically we indent four spaces after the &&
Collaborator
Author
There was a problem hiding this comment.
@dani-zilla please let me know if it's alright now
shamim-emon
force-pushed
the
fix-issue-10540
branch
from
6540cd3 to
afac56e
Compare
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
shamim-emon
force-pushed
the
fix-issue-10540
branch
3 times, most recently
from
673e4cb to
521bf57
Compare
shamim-emon
force-pushed
the
fix-issue-10540
branch
from
521bf57 to
915bcec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Message view action visibility (Archive, Delete, Move, Copy, Spam) was still relying on legacy K9.isMessageView preference accessors. This PR migrates message view action visibility logic to use the modern PreferenceDataStore-backed APIs.
🎯 Benefits