Skip to content

refactor: relocate showAccountSelector from DrawerConfiguration to DrawerState#10528

Merged
wmontwe merged 4 commits intothunderbird:mainfrom
shamim-emon:fix-issue-10527
Feb 13, 2026
Merged

refactor: relocate showAccountSelector from DrawerConfiguration to DrawerState#10528
wmontwe merged 4 commits intothunderbird:mainfrom
shamim-emon:fix-issue-10527

Conversation

@shamim-emon
Copy link
Collaborator

@shamim-emon shamim-emon commented Feb 12, 2026

Implementation Highlights

  • Hoist showAccountSelector from DrawerConfig to DrawerState.
  • Remove the static K9.showAccountSelector and eliminate its associated persistence logic.
  • Updated relevant ViewModel logic
  • Updated below tests to to reflect the hoisting:
    • DrawerStateTest
    • DrawerViewModelTest
    • GetDrawerConfigTest

Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just keep the ACCOUNT_CLOSE_DELAY please.

@shamim-emon shamim-emon requested a review from wmontwe February 12, 2026 17:38
@wmontwe wmontwe removed the request for review from rafaeltonholo February 13, 2026 08:16
@wmontwe wmontwe changed the title Relocate showAccountSelector from DrawerConfiguration to DrawerState refactor: relocate showAccountSelector from DrawerConfiguration to DrawerState Feb 13, 2026
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wmontwe wmontwe merged commit 8b7494a into thunderbird:main Feb 13, 2026
13 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 17 milestone Feb 13, 2026
@shamim-emon shamim-emon deleted the fix-issue-10527 branch February 13, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relocate showAccountSelector from DrawerConfiguration to DrawerState

3 participants