Skip to content

Update OIDC external connection with preferred_username instead of email#1649

Merged
davinotdavid merged 3 commits intomainfrom
update-oidc-token-during-login
Apr 27, 2026
Merged

Update OIDC external connection with preferred_username instead of email#1649
davinotdavid merged 3 commits intomainfrom
update-oidc-token-during-login

Conversation

@davinotdavid
Copy link
Copy Markdown
Contributor

@davinotdavid davinotdavid commented Apr 23, 2026

What changed?

Upon login, we are updating the OIDC external connection's name to be the preferred_username or username fields from the token.

Why?

We can't use email anymore since this is being remapped (used to be the recovery email field during signup).

Applicable Issues

Fixes #1647

Copy link
Copy Markdown
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd take a look at the comments and fix the test though.

Comment thread backend/src/appointment/routes/auth.py Outdated
Comment thread backend/test/integration/test_auth.py Outdated
@davinotdavid davinotdavid merged commit a9b7c52 into main Apr 27, 2026
8 checks passed
@davinotdavid davinotdavid deleted the update-oidc-token-during-login branch April 27, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the oidc token during login

2 participants