refactor!: replace DepthTo3DLocations sensor args with SensorConfig sequence#856
Open
TimothyAlexisVass wants to merge 7 commits intothousandbrainsproject:mainfrom
Conversation
Contributor
|
note: Added breaking change |
Contributor
Author
|
@tristanls-tbp If we want backwards compatibility instead of making this a breaking change, I did prepare that. |
Contributor
Contributor
|
Hi @TimothyAlexisVass, ok, we reworked how we do configurations in #857, which is now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to
@tristanls-tbp
Summary
This follow-up PR removes legacy parallel/union constructor inputs from
DepthTo3DLocationsand enforces a single, typed configuration path viaSequence[SensorConfig].Changes
DepthTo3DLocations.__init__now requiressensor_configs: Sequence[SensorConfig].sensor_ids,resolutions,zooms, andhfovwere removed.Most of the files changed are .yaml configs and snapshots, updated to the new SensorConfig contract:
Scope / Behavior
SensorConfigcontinue to work.DepthTo3DLocations.DepthTo3DLocationswith old positional args (sensor_ids,resolutions,zooms,hfov) and is not migrated toSensorConfig.If any unexpected callers require backwards-compatibility to the legacy arguments, that is already prepared and we could drop commit 305b918.